kube play: only enforce passthrough in Quadlet #17548
Conversation
Only enforce the passthrough log driver for Quadlet. Commit 68fbebf introduced a regression on the `podman-kube@` template as `podman logs` stopped working and settings from containers.conf were ignored. Fixes: containers#17482 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@containers/podman-maintainers PTAL |
|
Can we still merge to 4.4.1-rhel? |
|
/cherry-pick v4.4 |
|
@vrothberg: once the present PR merges, I will cherry-pick it on top of v4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@vrothberg: new pull request created: #17553 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick v4.4.1-rhel |
|
@vrothberg: new pull request created: #17570 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
Only enforce the passthrough log driver for Quadlet. Commit 68fbebf introduced a regression on the
podman-kube@template aspodman logsstopped working and settings from containers.conf were ignored.Fixes: #17482
Does this PR introduce a user-facing change?