Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] copr: podman.spec.rpkg cleanups #17527

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Feb 16, 2023

  • Remove f35 conditionals, list manpages only once.
  • Fix el8 builds the right way.

Does this PR introduce a user-facing change?

None

@containers/podman-maintainers PTAL
Successful copr build: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/5533400/

- Remove f35 conditionals, list manpages only once.
- Fix el8 builds the right way.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 16, 2023
@lsm5 lsm5 requested a review from rhatdan February 16, 2023 13:05
@rhatdan
Copy link
Member

rhatdan commented Feb 16, 2023

LGTM
@containers/podman-maintainers PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 33622f7 into containers:main Feb 17, 2023
@lsm5 lsm5 deleted the copr-fixes branch February 17, 2023 11:15
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants