Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube: rm secret on down, print secret on play #17526

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions cmd/podman/kube/play.go
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ func teardown(body io.Reader, options entities.PlayKubeDownOptions, quiet bool)
podStopErrors utils.OutputErrors
podRmErrors utils.OutputErrors
volRmErrors utils.OutputErrors
secRmErrors utils.OutputErrors
)
reports, err := registry.ContainerEngine().PlayKubeDown(registry.GetContext(), body, options)
if err != nil {
Expand Down Expand Up @@ -377,6 +378,24 @@ func teardown(body io.Reader, options entities.PlayKubeDownOptions, quiet bool)
fmt.Fprintf(os.Stderr, "Error: %s\n", lastPodRmError)
}

// Output rm'd volumes
if !quiet {
fmt.Println("Secrets removed:")
}
for _, removed := range reports.SecretRmReport {
switch {
case removed.Err != nil:
secRmErrors = append(secRmErrors, removed.Err)
case quiet:
default:
fmt.Println(removed.ID)
}
}
lastSecretRmError := secRmErrors.PrintErrors()
if lastPodRmError != nil {
fmt.Fprintf(os.Stderr, "Error: %s\n", lastSecretRmError)
}

// Output rm'd volumes
if !quiet {
fmt.Println("Volumes removed:")
Expand Down Expand Up @@ -407,6 +426,14 @@ func kubeplay(body io.Reader) error {
fmt.Println(volume.Name)
}

// Print secrets report
for i, secret := range report.Secrets {
if i == 0 {
fmt.Println("Secrets:")
}
fmt.Println(secret.CreateReport.ID)
}

// Print pods report
for _, pod := range report.Pods {
for _, l := range pod.Logs {
Expand Down
1 change: 1 addition & 0 deletions pkg/domain/entities/play.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ type PlayKubeTeardown struct {
StopReport []*PodStopReport
RmReport []*PodRmReport
VolumeRmReport []*VolumeRmReport
SecretRmReport []*SecretRmReport
}

type PlaySecret struct {
Expand Down
12 changes: 12 additions & 0 deletions pkg/domain/infra/abi/play.go
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,7 @@ func (ic *ContainerEngine) PlayKubeDown(ctx context.Context, body io.Reader, opt
var (
podNames []string
volumeNames []string
secretNames []string
)
reports := new(entities.PlayKubeReport)

Expand Down Expand Up @@ -1313,6 +1314,12 @@ func (ic *ContainerEngine) PlayKubeDown(ctx context.Context, body io.Reader, opt
return nil, fmt.Errorf("unable to read YAML as Kube PersistentVolumeClaim: %w", err)
}
volumeNames = append(volumeNames, pvcYAML.Name)
case "Secret":
var secret v1.Secret
if err := yaml.Unmarshal(document, &secret); err != nil {
return nil, fmt.Errorf("unable to read YAML as Kube Secret: %w", err)
}
secretNames = append(secretNames, secret.Name)
default:
continue
}
Expand All @@ -1329,6 +1336,11 @@ func (ic *ContainerEngine) PlayKubeDown(ctx context.Context, body io.Reader, opt
return nil, err
}

reports.SecretRmReport, err = ic.SecretRm(ctx, secretNames, entities.SecretRmOptions{})
if err != nil {
return nil, err
}

if options.Force {
reports.VolumeRmReport, err = ic.VolumeRm(ctx, volumeNames, entities.VolumeRmOptions{})
if err != nil {
Expand Down
31 changes: 31 additions & 0 deletions test/e2e/play_kube_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1688,6 +1688,12 @@ func createAndTestSecret(podmanTest *PodmanTestIntegration, secretYamlString, se
secretList.WaitWithDefaultTimeout()
Expect(secretList).Should(Exit(0))
Expect(secretList.OutputToString()).Should(ContainSubstring(secretName))

// test if secret ID is printed once created
secretListQuiet := podmanTest.Podman([]string{"secret", "list", "--quiet"})
secretListQuiet.WaitWithDefaultTimeout()
Expect(secretListQuiet).Should(Exit(0))
Expect(kube.OutputToString()).Should(ContainSubstring(secretListQuiet.OutputToString()))
}

func deleteAndTestSecret(podmanTest *PodmanTestIntegration, secretName string) {
Expand Down Expand Up @@ -3863,6 +3869,31 @@ invalid kube kind
Expect(checkls.OutputToStringArray()).To(BeEmpty())
})

It("podman play kube teardown with secret", func() {
err := writeYaml(secretYaml, kubeYaml)
Expect(err).ToNot(HaveOccurred())

kube := podmanTest.Podman([]string{"kube", "play", kubeYaml})
kube.WaitWithDefaultTimeout()
Expect(kube).Should(Exit(0))
vrothberg marked this conversation as resolved.
Show resolved Hide resolved

ls := podmanTest.Podman([]string{"secret", "ls", "--format", "{{.ID}}"})
ls.WaitWithDefaultTimeout()
Expect(ls).Should(Exit(0))
Expect(ls.OutputToStringArray()).To(HaveLen(1))

// teardown
teardown := podmanTest.Podman([]string{"kube", "down", kubeYaml})
teardown.WaitWithDefaultTimeout()
Expect(teardown).Should(Exit(0))
danishprakash marked this conversation as resolved.
Show resolved Hide resolved
Expect(teardown.OutputToString()).Should(ContainSubstring(ls.OutputToString()))

checkls := podmanTest.Podman([]string{"secret", "ls", "--format", "'{{.ID}}'"})
checkls.WaitWithDefaultTimeout()
Expect(checkls).Should(Exit(0))
Expect(checkls.OutputToStringArray()).To(BeEmpty())
})

It("podman play kube teardown pod does not exist", func() {
// teardown
teardown := podmanTest.Podman([]string{"play", "kube", "--down", kubeYaml})
Expand Down