system tests: prevent leading tabs

[edsantiago]

Replace existing tab indentations with spaces, and add
a test to CI to prevent new ones from sneaking in.

Signed-off-by: Ed Santiago [email protected]

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Checking for leading tabs in system tests
test/system/800-config.bats:65:	is "$output" "Error:.*no such container" "unexpected error from podman wait"
************************************************
ERROR: Found leading tabs in system tests. Use spaces to indent, not tabs.  (contrib/cirrus/prebuild.sh:33 in main())
************************************************

This was intentional, as confirmation that the new no-more-tabs check works. It does. Repushed with clean tab-less code.

[Luap99]

Yes, please
LGTM!

[Luap99]

If we do not want to blow up CI on main, we should properly check other PRs for tabs before we merge this.

[edsantiago]

Well, #17386 is the obvious one. If that one merges first, I will rebase mine. But I do hope Dan fixes the whitespace issues before that merges.

I have no automated way to check in-flight PRs, so if worst comes to worst, it'll have to be fixed in the affected PRs.

[vrothberg]

/lgtm

Farewell my beloved tabs...