-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental workaround for cdn03.quay.io flake #17505
Conversation
69fa82a
to
ad40da7
Compare
contrib/cirrus/setup_environment.sh
Outdated
systemctl start NetworkManager | ||
|
||
# Sigh. The first time, NetworkManager doesn't seem | ||
# to create a resolv.conf. Keep retrying until it does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to restart it, systemd will ignore start when a unit it is already running and AFAIK NetworkManager should already be running unless we explicitly disabled it use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, could be. On a 1minutetip VM it was not started by default. Anyhow, no flakes in two runs, I'm going to keep hammering away at CI with this to see how it goes. Thanks for the suggestion.
fe44d73
to
ddb2d8f
Compare
Five (six?) runs, and no sign of the flake; but here's the flake, right now, in a different PR: https://cirrus-ci.com/task/5480576929497088 |
I can't find instances of the "lookup cdn03.quay.io" flake in RHEL gating tests. RHEL does not use systemd-resolved. Maybe pure coincidence. Maybe not. Let's try disabling systemd-resolved and see how things go. Signed-off-by: Ed Santiago <[email protected]>
I lost count of the retries. None failed with the @containers/podman-maintainers it makes me queasy to ask this, but please review and merge if you see fit. I'd like to reevaluate in a few weeks, see if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added a reminder to my calendar.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
Reminder kicked in. @edsantiago, all good with this change? |
Oh, interesting. Here's the
...and of those, some are in "Build" step (which ISTR happens before my disable-systemd code?) and the rest are in |
Can we disable it when building the VM images? |
Probably worth reporting the bug as well. |
/cherrypick v4.4 |
@cevich: only containers org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I can't find instances of the "lookup cdn03.quay.io" flake
in RHEL gating tests. RHEL does not use systemd-resolved.
Maybe pure coincidence. Maybe not.
Signed-off-by: Ed Santiago [email protected]