Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor c/image after EOF heuristic tuning #17492

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Feb 13, 2023

Test further relaxing the “unexpected EOF” heuristic, with the intent to allow one retry a minute even if we made little progress (in particular, this could help with the failures very soon after the initial connection like #17193 (comment) ).

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2023
... for Podman to immediately benefit from the updated heuristic.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac changed the title DO NOT MERGE: Vendor https://github.com/containers/image/pull/1847 Vendor c/image after EOF heuristic tuning Feb 14, 2023
@mtrmac
Copy link
Collaborator Author

mtrmac commented Feb 14, 2023

containers/image#1847 was merged in c/image; so updating this PR to bring it into Podman immediately, hopefully improving the flake situation.

@mtrmac mtrmac marked this pull request as ready for review February 14, 2023 17:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 15, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 166f3df into containers:main Feb 15, 2023
@mtrmac mtrmac deleted the c-image-eof2 branch February 15, 2023 17:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants