fix != filter in volume prune #17483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
approved these changes
Feb 13, 2023
openshift-ci
bot
added
the
approved
|
Maybe rebasing on the latest HEAD will help |
vyasgun
force-pushed
the
pr/filter-fix
branch
from
1da95c3 to
5278f4b
Compare
|
@vrothberg Thanks for the review. I have rebased and updated the PR -- hopefully it will resolve the issue. |
openshift-ci
bot
added
the
do-not-merge/hold
|
Tests aren´t happy yet |
|
Yes, it's my tests. Taking a look |
flouthoc
reviewed
Feb 13, 2023
vyasgun
force-pushed
the
pr/filter-fix
branch
from
5278f4b to
65f5bfb
Compare
vyasgun
force-pushed
the
pr/filter-fix
branch
from
65f5bfb to
b70e7d1
Compare
I found the error in CI, yep just needed to rebase to fix that. |
Signed-off-by: vyasgun <[email protected]>
vyasgun
force-pushed
the
pr/filter-fix
branch
from
b70e7d1 to
33a9187
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vyasgun [email protected]
Fixes #17051
Does this PR introduce a user-facing change?