Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quadlet: Add support for the Secret key in Container group #17423

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Quadlet: Add support for the Secret key in Container group #17423

merged 1 commit into from
Feb 8, 2023

Conversation

ygalblum
Copy link
Contributor

@ygalblum ygalblum commented Feb 8, 2023

Add E2E tests
Add system test
Add to man page

Signed-off-by: Ygal Blum [email protected]

Does this PR introduce a user-facing change?

Yes

Quadlet: Add support for the Secret key in Container group

@ygalblum
Copy link
Contributor Author

ygalblum commented Feb 8, 2023

@vrothberg I would like to use this capability in the demo code for the blog post. Can this change be merged to 4.4.x?

@vrothberg
Copy link
Member

vrothberg commented Feb 8, 2023 •
edited
Loading

@vrothberg I would like to use this capability in the demo code for the blog post. Can this change be merged to 4.4.x?

No new features for 4.4 anymore :( Can you use PodmanArgs instead and mention that it'll be a 4.5 feature?

vrothberg
vrothberg approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@vrothberg
Copy link
Member

@rhatdan @alexlarsson PTAL

@ygalblum
Copy link
Contributor Author

ygalblum commented Feb 8, 2023

@vrothberg I would like to use this capability in the demo code for the blog post. Can this change be merged to 4.4.x?

No new features for 4.4 anymore :( Can you use PodmanArgs instead and mention that it'll be a 4.5 feature?

I guess I can use PodmanArgs, it just won't be as clean :(. But, rules are rules

@ygalblum
Quadlet: Add support for the Secret key in Container group
d6dd17f 
Add E2E tests
Add system test
Add to man page

Signed-off-by: Ygal Blum <[email protected]>
@ygalblum ygalblum force-pushed the quadlet_container_secret branch from beeea61 to d6dd17f Compare February 8, 2023 14:12
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Feb 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@rhatdan rhatdan removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 34e76a4 into containers:main Feb 8, 2023
@ygalblum ygalblum deleted the quadlet_container_secret branch February 9, 2023 04:37
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ygalblum @vrothberg @openshift-merge-robot @rhatdan