Add ctrName to network alias during kube play #17412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
Luap99
reviewed
Feb 7, 2023
github-actions
bot
added
the
kind/api-change
umohnani8
force-pushed
the
alias
branch
2 times, most recently
from
e599cdc to
b29ff12
Compare
github-actions
bot
removed
the
kind/api-change
Luap99
reviewed
Feb 8, 2023
umohnani8
force-pushed
the
alias
branch
2 times, most recently
from
ca402bc to
ce823cb
Compare
Luap99
reviewed
Feb 8, 2023
We currently name the container being created during kube play as ctrName-podName, but this is not how it is done in k8s. Since we can't change this at the CLI level as it will be a breaking change (it will be planned for podman 5.0), add only ctrName as an alias to the network of the pod. Signed-off-by: Urvashi Mohnani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently name the container being created during kube play as ctrName-podName, but this is not how it is done in k8s. Since we can't change this at the CLI level as it will be a breaking change (it will be planned for podman 5.0), add only ctrName as an alias to the network of the pod.
Partially fixes #16544 - a follow up during podman 5.0 will be needed to make the breaking CLI change.
Signed-off-by: Urvashi Mohnani [email protected]
Does this PR introduce a user-facing change?