[CI:BUILD] Cirrus: Fix GraphQL ownerRepository:null error #17383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b3073f. Signed-off-by: Chris Evich <[email protected]>
openshift-ci
bot
added
do-not-merge/work-in-progress
cevich
force-pushed
the
revert_emergency_fix
branch
2 times, most recently
from
aa2a033 to
96f029a
Compare
cevich
changed the title
cevich
force-pushed
the
revert_emergency_fix
branch
from
96f029a to
92c7b5c
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
A semantic change to a Cirrus-CI GraphQL API parameter caused a
unit-test to fail (as it should have) with the error:
```
Query result did not pass filter '.data.ownerRepository.cronSettings':
'{"data":{"ownerRepository":null}}'
```
As per Cirrus-support, a change was introduced in schema affecting certain
fields that were incorrectly marked Nullable. They indicated the `platform`
field was set incorrectly, and should use the value `github`.
* Fix the platform field's value to `github` instead of `LINUX`.
* Change the unit-test to only execute as part of the 'main' cirrus-cron
job so it cannot impact PRs.
Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
revert_emergency_fix
branch
from
92c7b5c to
50f72fe
Compare
|
@containers/podman-maintainers PTAL. This fixes the underlying problem & test which lead to the big CI-SNAFU on Monday. Without this PR merged, all our cirrus-cron monitoring jobs fail. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 7, 2023
These tests don't need to run for every PR, and the thing they're testing never runs on any branch except `main`. Stop them from running on this branch. In case someone decides to try and use them, also fix the errant API call which triggered the original problem. Ref: containers#17383 Signed-off-by: Chris Evich <[email protected]>
|
/cherry-pick v4.4 |
|
@lsm5: #17383 failed to apply on top of branch "v4.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ah I see it's cherrypicked already. my bad. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A semantic change to a Cirrus-CI GraphQL API parameter caused a
unit-test to fail (as it should have) with the error:
As per Cirrus-support, a change was introduced in schema affecting certain
fields that were incorrectly marked Nullable. They indicated the
platformfield was set incorrectly, and should use the value
github.githubinstead ofLINUX.job so it cannot impact PRs.
Does this PR introduce a user-facing change?