Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/container-orchestrated-devices/container-device-interface from 0.5.3 to 0.5.4 #17375

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 6, 2023

Bumps github.com/container-orchestrated-devices/container-device-interface from 0.5.3 to 0.5.4.

Release notes

Sourced from github.com/container-orchestrated-devices/container-device-interface's releases.

v0.5.4

What's Changed

New Contributors

Full Changelog: cncf-tags/container-device-interface@v0.5.3...v0.5.4

Commits
  • 0a1a5be Merge pull request #106 from klihub/fixes/cmd-cdi-deps
  • ad5beee cmd/cdi: update/fix go.{mod,sum}.
  • 95791ea Merge pull request #103 from klihub/fixes/split-cdi-binary
  • 5b3b5d8 Merge pull request #93 from elezar/min-spec-version
  • cafeaf8 cmd/cdi: split out to a module of its own.
  • 1a1203c Add semver package to module
  • 801f1ad Set earliest supported spec verison to v0.3.0
  • 42cb494 Refactor version checks
  • 8729204 Add spec version validation
  • 893254c Add MinimumRequiredVersion function to spec
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Feb 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch from d787268 to 6bf4320 Compare February 6, 2023 20:09
@vrothberg
Copy link
Member

Needs manual intervention. I'll take a look.

@vrothberg vrothberg force-pushed the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch from 6bf4320 to 99c83a4 Compare February 8, 2023 12:48
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@vrothberg vrothberg force-pushed the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch from 99c83a4 to 692e181 Compare February 8, 2023 12:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@vrothberg vrothberg force-pushed the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch from 692e181 to c8fb9c9 Compare February 8, 2023 13:15
@vrothberg
Copy link
Member

@giuseppe can you take a look at the failure? I am not familiar with this code.

@giuseppe giuseppe force-pushed the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch from c8fb9c9 to 32cf4c4 Compare February 9, 2023 10:41
@giuseppe
Copy link
Member

giuseppe commented Feb 9, 2023

it seems like a breaking change in the dependency, the first commits that breaks the test is:

commit 801f1ad87b98012473347ff8892bd8338768f0fb
Author: Evan Lezar <[email protected]>
Date:   Wed Nov 9 12:08:34 2022 +0100

    Set earliest supported spec verison to v0.3.0
    
    Signed-off-by: Evan Lezar <[email protected]>

so a s/0.2.0/0.3.0/ in test/e2e/cdi/device.json seems to do the trick

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2023
…-device-interface

Bumps [github.com/container-orchestrated-devices/container-device-interface](https://github.com/container-orchestrated-devices/container-device-interface) from 0.5.3 to 0.5.4.
- [Release notes](https://github.com/container-orchestrated-devices/container-device-interface/releases)
- [Commits](cncf-tags/container-device-interface@v0.5.3...v0.5.4)

---
updated-dependencies:
- dependency-name: github.com/container-orchestrated-devices/container-device-interface
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

[NO NEW TESTS NEEDED]

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg force-pushed the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch from 32cf4c4 to e9942c6 Compare February 20, 2023 13:53
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2023
@vrothberg
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@vrothberg
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 80c5896 into main Feb 20, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.4 branch February 20, 2023 15:34
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants