Move clean-binaries before podman-remote in podman-remote-docs target
#17367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run make with muitiple jobs, `clean-binaries` could run after the `podman-remote` target thus delete the newly built `podman-remote` binary file. And this would cause the error later in the `docs/remote-docs.sh` script. Signed-off-by: xxyzz <[email protected]>
6 tasks
vrothberg
approved these changes
Feb 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg, xxyzz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run make with muitiple jobs,
clean-binariescould run after thepodman-remotetarget thus delete the newly builtpodman-remotebinary file. And this would cause the error later in thedocs/remote-docs.shscript.I feel like build podman-remote here is unnecessary, make should build it automatically if it's changed.
Does this PR introduce a user-facing change?