-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system tests: fix noexistent labels test in the remote #17347
system tests: fix noexistent labels test in the remote #17347
Conversation
In the remote environment, this test will be failed, because an error message is different from the local environment. Signed-off-by: Toshiki Sonoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edsantiago PTAL
Why wasn't this test failing in the CI/CD system? Don't we test this in --remote mode? |
/lgtm |
The CI/CI system currently doesn't run with runc, only with crun. |
In the remote environment, this test will be failed,
because an error message is different from the local environment.
Signed-off-by: Toshiki Sonoda [email protected]
test log in the remote environment
Does this PR introduce a user-facing change?