Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: fix noexistent labels test in the remote #17347

Merged

Conversation

sstosh
Copy link
Contributor

@sstosh sstosh commented Feb 3, 2023

In the remote environment, this test will be failed,
because an error message is different from the local environment.

Signed-off-by: Toshiki Sonoda [email protected]


  • Error message (local)
Error: OCI runtime error: runc: runc create failed: unable to start container process: error during container init: write /proc/self/attr/keycreate: invalid argument
  • Error message (remote)
Error: preparing container <cid> for attach: runc: runc create failed: unable to start container process: error during container init: write /proc/self/attr/keycreate: invalid argument: OCI runtime error
test log in the remote environment
not ok 1 podman with nonexistent labels
# (from function `is' in file helpers.bash, line 742,
#  in test file test.bats, line 59)
#   `is "$output" "Error.*: $expect" "podman emits useful diagnostic on failure"' failed with status 126
# # /usr/bin/podman-remote rm -t 0 --all --force --ignore
# # /usr/bin/podman-remote ps --all --external --format {{.ID}} {{.Names}}
# # /usr/bin/podman-remote images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
# quay.io/libpod/testimage:20220615 f26aa69bb3f3
# # /usr/bin/podman-remote run --security-opt label=type:foo.bar quay.io/libpod/testimage:20220615 true
# Error: preparing container c8b7164e1805d057241a6ea507b676b4e20be2d94c1395aa965b09b4d36e47d5 for attach: runc: runc create failed: unable to start container process: error during container init: write /proc/self/attr/keycreate: invalid argument: OCI runtime error
# [ rc=126 (expected) ]
# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: podman emits useful diagnostic on failure
# #| expected: 'Error.*: OCI runtime error: .*: \(failed to set\|write\) /proc/self/attr/keycreate.*' (using expr)
# #|   actual: 'Error: preparing container c8b7164e1805d057241a6ea507b676b4e20be2d94c1395aa965b09b4d36e47d5 for attach: runc: runc create failed: unable to start container process: error during container init: write /proc/self/attr/keycreate: invalid argument: OCI runtime error'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# # [teardown]
# # /usr/bin/podman-remote pod rm -t 0 --all --force --ignore
# # /usr/bin/podman-remote rm -t 0 --all --force --ignore
# c8b7164e1805d057241a6ea507b676b4e20be2d94c1395aa965b09b4d36e47d5
# # /usr/bin/podman-remote network prune --force

Does this PR introduce a user-facing change?

None

In the remote environment, this test will be failed,
because an error message is different from the local environment.

Signed-off-by: Toshiki Sonoda <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, sstosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2023

Why wasn't this test failing in the CI/CD system? Don't we test this in --remote mode?

@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 51dd01c into containers:main Feb 3, 2023
@sstosh sstosh deleted the system-nonexistent-labels branch February 3, 2023 23:16
@sstosh
Copy link
Contributor Author

sstosh commented Feb 6, 2023

Why wasn't this test failing in the CI/CD system? Don't we test this in --remote mode?

The CI/CI system currently doesn't run with runc, only with crun.
Therefore, this failure wasn't detected.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants