-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adapt test to work on cgroupv1 #17343
test: adapt test to work on cgroupv1 #17343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails rootless
when running on a cgroupv1 host validate that the memory controller is mounted ro. Signed-off-by: Giuseppe Scrivano <[email protected]>
628c263
to
ed1f769
Compare
LGTM, thank you! |
@vrothberg PTAL :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick v4.4 |
@rhatdan: new pull request created: #17361 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
when running on a cgroupv1 host validate that the memory controller is mounted ro.
Signed-off-by: Giuseppe Scrivano [email protected]
Does this PR introduce a user-facing change?