Emergency fix for RHEL8 gating tests #17311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because systemd on RHEL8 is too old, has no -P Signed-off-by: Ed Santiago <[email protected]>
openshift-ci
bot
added
release-note-none
approved
|
LGTM |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Did you open a PR for main? We should not merge stuff that has no main PR otherwise we just regress with the next release again. |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Feb 1, 2023
quadlet tests were using 'systemctl show -P', a shortcut that doesn't exist on RHEL8. Translate to old-systemd language. And, minor tweaks to make future test diagnosing easier. This is a frontport of containers#17311; bringing from release branch to main. Except that was an emergency, so it was a one-line fix. This is a better long-term fix, not as trivial to review. Signed-off-by: Ed Santiago <[email protected]>
|
#17320 on main. That's what this PR started off as, before I decided to make it simple. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because systemd on RHEL8 is too old, has no -P
Signed-off-by: Ed Santiago [email protected]