-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not mount /dev/tty into rootless containers #17304
Do not mount /dev/tty into rootless containers #17304
Conversation
a8c6383
to
2574b8f
Compare
I would like to write more tests to catch regressions like this one, but I can't do it now. This could however be landed in a separate PR :) |
could you please add |
[NO NEW TESTS NEEDED] Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2165875 Signed-off-by: Martin Roukala (né Peres) <[email protected]>
2574b8f
to
d10860a
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mupuf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mheon PTAL |
/lgtm Let's get this cherry-picked in 4.4 before we do v4.4.0 |
/hold cancel |
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2165875
Does this PR introduce a user-facing change?
This PR should superseed #17301.
@giuseppe: This should address the regression, without needing to revert the commits (which were themselves fixing a regression).