Fix default handling of pids-limit #17262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to verify that updates without a pids-limit specified no longer overwrite the previous value. Also fixes erroneous warning generated by remote clients: "Resource limits are not supported and ignored on cgroups V1 rootless systems" Signed-off-by: Jason T. Greene <[email protected]>
openshift-ci
bot
added
release-note-none
approved
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick v4.4 |
|
@baude: new pull request created: #17355 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed container creation/run commands on podman remote were printing:
"Resource limits are not supported and ignored on cgroups V1 rootless systems"
The underlying cause was a problem with default handling introduced in the enhancement that added pids-limit for container update operations (479052a)
This also meant that updates for other values would unintentionally change the pids-limit back to the default value. This PR adds a test for that condition as well.
Signed-off-by: Jason T. Greene [email protected]
Does this PR introduce a user-facing change?