-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: running check error when podman is default in wsl #17228
fix: running check error when podman is default in wsl #17228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
In order to pass CI, could you add the magic string [NO NEW TESTS NEEDED]
to your commit message and repush?
@n1hility PTAL
Thanks for the PR! it looks like this is triggered when running under locales with different spacing rules (the previous code had a faulty assumption the wsl command output would always include a space between the name and the default signifier column). /approve |
I rebased the change with the no tests flag, so once this is green we can merge. |
@n1hility Thank you for your feedback. |
It looks like a bad test was merged earlier. I will look into it. |
Please rebase once #17247 got merged and the test will pass again. Sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, shblue21, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If podman is the default wsl distribution, the (default) string is appended and result is assigned false. [NO NEW TESTS NEEDED] Fixes #17227 Signed-off-by: shblue21 <[email protected]>
/lgtm |
/cherrypick v4.4 |
@rhatdan: new pull request created: #17256 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@shblue21 thanks again for the PR and using podman. We appreciate the help! |
If podman is set to the wsl default distribution, the (default) value is appended like podman-machine-default (default).
Because of (default), it determines that podman wsl deployment has not been executed.
It can be solved simply by outputting only the wsl distribution name with the --quiet option.
Related to #17227, #17158
Signed-off-by: shblue21 [email protected]
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED]