ps: query health check in batch mode #17211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Luap99
reviewed
Jan 25, 2023
Also do not return (and immediately suppress) an error if no health check is defined for a given container. Makes listing 100 containers around 10 percent faster. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
Luap99
reviewed
Jan 25, 2023
| return c.healthCheckStatus() | ||
| } | ||
|
|
||
| // Internal function to return the current state of a container with a healthcheck. | ||
| // This function does not lock the container. | ||
| func (c *Container) healthCheckStatus() (string, error) { | ||
| if !c.HasHealthCheck() { | ||
| return "", fmt.Errorf("container %s has no defined healthcheck", c.ID()) | ||
| return "", nil | ||
| } | ||
|
|
||
| if err := c.syncContainer(); err != nil { |
There was a problem hiding this comment.
I think the syncContainer() here should be moved in the if !batched branch just like the other public accessor functions
There was a problem hiding this comment.
I am sure there's more to polish in the health-check code but it's out of scope of this PR.
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do not return (and immediately suppress) an error if no health check is defined for a given container.
Makes listing 100 containers around 10 percent faster.
[NO NEW TESTS NEEDED]
Signed-off-by: Valentin Rothberg [email protected]
@containers/podman-maintainers PTAL
Does this PR introduce a user-facing change?