Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for limiting tmpfs size for systemd-specific mnts #17207

Merged
merged 1 commit into from
Feb 15, 2023
Merged

add support for limiting tmpfs size for systemd-specific mnts #17207

merged 1 commit into from
Feb 15, 2023

Conversation

danishprakash
Copy link
Contributor

@danishprakash danishprakash commented Jan 25, 2023 •
edited
Loading

Add support for limiting tmpfs size for systemd-specific mounts via --shm-size-systemd

Closes #17037

Signed-off-by: danishprakash [email protected]

Does this PR introduce a user-facing change?

- Add support for limiting tmpfs size for systemd-specific mounts via `--shm-size-systemd`

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 25, 2023
@danishprakash
Copy link
Contributor Author

danishprakash commented Jan 25, 2023 •
edited
Loading

@rhatdan based on this comment of yours, majority of the mounts are being governed by --shm-size barring the following:

/run
/run/lock
/var/log/journal
/tmp

and the others are read-only. I'm guessing limiting the above mounts based on a flag should suffice?

@rhatdan
Copy link
Member

rhatdan commented Jan 25, 2023

Yes I agree.

@rhatdan
Copy link
Member

rhatdan commented Jan 25, 2023

Needs documentation, command completions and tests.

@danishprakash danishprakash force-pushed the add-systemd-shm-size branch 4 times, most recently from 068630b to 61611dc Compare February 6, 2023 12:30
@danishprakash danishprakash marked this pull request as ready for review February 6, 2023 12:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2023

Please rebase so that this can pass CI/CD

@danishprakash
Copy link
Contributor Author

Sure, I was also confused as to why that test was failing, thanks for the heads up.

@danishprakash danishprakash force-pushed the add-systemd-shm-size branch 5 times, most recently from fd5188a to 9ceb441 Compare February 7, 2023 06:39
@danishprakash
Copy link
Contributor Author

@vrothberg @rhatdan sorry for tagging but I'm unable to figure out why cirrus is erroring out here. Would really like some hints here. Thanks

@vrothberg
Copy link
Member

Thanks for the ping! Apply the following diff and it should pass:

diff --git a/docs/source/markdown/options/shm-size-systemd.md b/docs/source/markdown/options/shm-size-systemd.md
index 8ea54c8d2..7fab8f5ab 100644
--- a/docs/source/markdown/options/shm-size-systemd.md
+++ b/docs/source/markdown/options/shm-size-systemd.md
@@ -1,5 +1,5 @@
 ####> This option file is used in:
-####>   podman run, create, pod clone, pod create
+####>   podman create, pod clone, pod create, run

@danishprakash danishprakash force-pushed the add-systemd-shm-size branch 4 times, most recently from 5cc3e53 to 5c33e94 Compare February 14, 2023 07:52
@danishprakash
add support for limiting tmpfs size for systemd-specific mnts
0999991 
* add tests
* add documentation for --shm-size-systemd
* add support for both pod and standalone run

Signed-off-by: danishprakash <[email protected]>
@danishprakash
Copy link
Contributor Author

@vrothberg could the failures be flakes? Can you please take a look?

@vrothberg
Copy link
Member

@vrothberg could the failures be flakes? Can you please take a look?

Thanks for the ping. They looked like flakes, so I have restarted the jobs.

vrothberg
vrothberg reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@giuseppe PTAL

@danishprakash danishprakash mentioned this pull request Feb 15, 2023
Merged
@rhatdan
Copy link
Member

rhatdan commented Feb 15, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danishprakash, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit eb75246 into containers:main Feb 15, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@giuseppe giuseppe giuseppe left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Set size limit for auto tmpfs mounts in systemd mode
5 participants
@danishprakash @rhatdan @vrothberg @giuseppe @openshift-merge-robot