Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-play: add support for HostPID #17168

Merged
merged 1 commit into from
Jan 20, 2023
Merged

kube-play: add support for HostPID #17168

merged 1 commit into from
Jan 20, 2023

Conversation

danishprakash
Copy link
Contributor

@danishprakash danishprakash commented Jan 20, 2023 •
edited
Loading

Adds support for hostPID in Pod manifest for podman kube play

Closes #17157

Does this PR introduce a user-facing change?

- play-kube: add support for hostPID in pod.spec

Signed-off-by: danishprakash [email protected]

Having some issues running the tests locally, hence the draft for now.

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 20, 2023
@danishprakash danishprakash force-pushed the add-host-pid branch 2 times, most recently from 5c95d68 to 9373549 Compare January 20, 2023 07:06
vrothberg
vrothberg reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling the issue! Can you squash the two commits into one? I think it's preferable to have tests and changes in one commit (easier to bisect if needed).

test/e2e/play_kube_test.go Show resolved Hide resolved
@danishprakash danishprakash marked this pull request as ready for review January 20, 2023 10:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@danishprakash
Copy link
Contributor Author

@vrothberg since the change for hostIPC seems similar, I was thinking of raising another PR for it, what do you suggest?

vrothberg
vrothberg reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@vrothberg
Copy link
Member

@vrothberg since the change for hostIPC seems similar, I was thinking of raising another PR for it, what do you suggest?

That sounds good, thanks!

@containers/podman-maintainers PTAL

giuseppe
giuseppe approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danishprakash, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@vrothberg
Copy link
Member

The test doesn't pass.

Luap99
Luap99 reviewed Jan 20, 2023
View reviewed changes
test/e2e/play_kube_test.go Outdated Show resolved Hide resolved
test/e2e/play_kube_test.go Outdated Show resolved Hide resolved
@danishprakash
kube-play: add support for HostPID in podSpec
3ae84fe 
* test/play_kube: add tests for hostPID

Signed-off-by: danishprakash <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@TomSweeneyRedHat
Copy link
Member

One nit to keep my OCD in check, otherwise LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 20, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8252dcc into containers:main Jan 20, 2023
@danishprakash danishprakash mentioned this pull request Jan 23, 2023
Merged
@edsantiago edsantiago mentioned this pull request Jan 25, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@vrothberg vrothberg vrothberg left review comments

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support HostPID in podman kube play
7 participants
@danishprakash @vrothberg @TomSweeneyRedHat @rhatdan @giuseppe @Luap99 @openshift-merge-robot