Cirrus: preserve podman-server logs

[edsantiago]

Output from podman system service, on system tests, is
being saved... it just hasn't been collected as an artifact.
Start collecting it. And, remove obsolete-unused-misleading
code that made me think it was being collected.

Also: log system-service output for bud tests

Signed-off-by: Ed Santiago [email protected]

None

[vrothberg]

LGTM

Thank you!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

/lgtm

[edsantiago]

/hold

[edsantiago]

I don't think it's working (logs missing) but I'll look after meeting

[Luap99]

I see the log attached: https://cirrus-ci.com/task/5479070318723072
https://api.cirrus-ci.com/v1/artifact/task/5479070318723072/server_log/podman-server.log

[edsantiago]

Yes, but only for system tests. I thought it would work for bud and int tests too, and it's not. I don't think there's any way I can log int, but I think it's not too hard to log bud. Am working on it.

[edsantiago]

Yay logs:

• f36 root
• f37 root
• f37 rootless
• f37-aarch64 root

...and now bud. Unfortunately, the bud log is empty apart from test names. All the other logs have stuff like "pulling images", "storing signatures". Does anyone know why there's nothing at all in the system-service logs for bud? Did I do something wrong?

[vrothberg]

Suggested change

	+ env CONTAINERS_CONF=${CONTAINERS_CONF:-$(dirname ${BASH_SOURCE})/containers.conf} $PODMAN_NATIVE system service --timeout=0 &>>${PODMAN_SERVER_LOG:-/dev/stderr} &
	+ env CONTAINERS_CONF=${CONTAINERS_CONF:-$(dirname ${BASH_SOURCE})/containers.conf} $PODMAN_NATIVE system service --timeout=0 &>>${$PODMAN_SERVER_LOG:-/dev/stderr} &

@edsantiago could this fix the issue? Not sure though ... bash isn't my strong suit.

[edsantiago]

That's actually a syntax error. The ${ VAR colon-minus default} means to use stderr if PODMAN_SERVER_LOG is unset:

$ echo ${PODMAN_SERVER_LOG:-/dev/stderr}
/dev/stderr
$ PODMAN_SERVER_LOG=/tmp/foo
$ echo ${PODMAN_SERVER_LOG:-/dev/stderr}
/tmp/foo

[Luap99]

...and now bud. Unfortunately, the bud log is empty apart from test names. All the other logs have stuff like "pulling images", "storing signatures". Does anyone know why there's nothing at all in the system-service logs for bud? Did I do something wrong?

the log level is warning by default, so it could be very wall that are no warning/error logged. The fact the we see pull progress on the server side also sounds like a bug to me and not a feature, why would anybody want that. I assume bud test do not require any pulls because the images are already present in the store.

[edsantiago]

we see pull progress on the server side also sounds like a bug to me

Oh, yeah. But it's existed so long that it's probably a feature now.

I assume bud test do not require any pulls because the images are already present in the store.

I haven't actually checked, but I used to be kinda-sure that some of the bud tests did image pulls? Like, isn't that why we see the quay03 flake in podman bud tests?

[Luap99]

I haven't actually checked, but I used to be kinda-sure that some of the bud tests did image pulls? Like, isn't that why we see the quay03 flake in podman bud tests?

Could be, maybe going through buildah just suppresses this output in the remote context for some reason.

If you want to make sure it works you could add --log-level=info, this might actually make more sense anyway because it would log the actual requests which will be useful for debugging.

[edsantiago]

you could add --log-level=info,

Good idea. Tested locally, I like the results (informative, not TOO noisy). May help someone in the future. Done and pushed. Thank you.

[edsantiago]

...and here's the podman server log for bud tests, with log-level info

/hold cancel

Ready to merge, if it meets team approval. Thanks for the advice.

[vrothberg]

/lgtm

Nice work, @edsantiago and @Luap99 !