Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-proxy system test: bump timeout #17141

Merged

Conversation

edsantiago
Copy link
Member

...and instrument with 'podman ps'es for debugging failures.

Test flakes pretty regularly in Fedora gating. If the increased
timeout doesn't help, at least we should be able to see if the
container is stopping or failed or something.

Closes: #16091

Signed-off-by: Ed Santiago [email protected]

None

...and instrument with 'podman ps'es for debugging failures.

Test flakes pretty regularly in Fedora gating. If the increased
timeout doesn't help, at least we should be able to see if the
container is stopping or failed or something.

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@edsantiago
Copy link
Member Author

Aw, phooey. @vrothberg is this related to yesterday's PR?

[+0290s] not ok 137 podman container rm --force doesn't leave running processes
...
         # # podman-remote --url unix:/tmp/podman_tmp_i9cG rm -f cTG9q6WAKk9c0Bvs343yuzK8rbPiBTs
         # Error: cannot remove container <sha> as it could not be stopped: given PIDs did not die within timeout

@edsantiago
Copy link
Member Author

And another one

@edsantiago
Copy link
Member Author

Filed #17142

@vrothberg
Copy link
Member

Aw, phooey. @vrothberg is this related to yesterday's PR?

[+0290s] not ok 137 podman container rm --force doesn't leave running processes
...
         # # podman-remote --url unix:/tmp/podman_tmp_i9cG rm -f cTG9q6WAKk9c0Bvs343yuzK8rbPiBTs
         # Error: cannot remove container <sha> as it could not be stopped: given PIDs did not die within timeout

Hard to say but it's extremely close to the code location. Could be another bug, could be a one off on a very busy node or something else.

@edsantiago
Copy link
Member Author

@containers/podman-maintainers PTAL, this is needed for Fedora gating tests

@mheon
Copy link
Member

mheon commented Jan 17, 2023

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit a702d44 into containers:main Jan 17, 2023
@edsantiago edsantiago deleted the bump_sigproxy_test_timeout branch January 17, 2023 20:57
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signal flake: Timed out waiting for BYE
5 participants