Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: version-check updates #17133

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Jan 16, 2023

Fix failures on main: https://cirrus-ci.com/task/5760364537708544?logs=main#L4216

docs/version-check
LATEST=v4.3.1
version-check: docs/tutorials/mac_win_client.md: needs updating.
version-check: Please run this script in an interactive shell, and I'll fix it.
version-check: docs/tutorials/podman-for-windows.md: needs updating.
version-check: Please run this script in an interactive shell, and I'll fix it.

Does this PR introduce a user-facing change?

None

Signed-off-by: Chris Evich <[email protected]>
@edsantiago
Copy link
Member

Diffs LGTM, I took the liberty of editing the github description so it actually includes the failure messages, (1) to save someone from having to click and (2) because the cirrus log will expire. Restarted the quay.io flake.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 16, 2023
@mheon
Copy link
Member

mheon commented Jan 16, 2023

/hold cancel
/approve

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 07ba51d into containers:main Jan 16, 2023
@lsm5
Copy link
Member

lsm5 commented Jan 17, 2023

while the change LGTM, wondering if markdown can allow version fetching from git tags so we don't have to change this every time.

@cevich cevich deleted the docs_update branch April 18, 2023 14:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants