rootless: rename auth-scripts to preexec-hooks #17118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
LGTM |
edsantiago
reviewed
Jan 16, 2023
test/system/950-auth-scripts.bats
Outdated
| PODMAN_AUTH_SCRIPTS_DIR=$auth_dir run_podman 42 pull foobar | ||
| PODMAN_AUTH_SCRIPTS_DIR=$auth_dir run_podman 43 pull barfoo | ||
| PODMAN_PREEXEC_HOOKS_DIR=$auth_dir run_podman 42 pull foobar | ||
| PODMAN_PREEXEC_HOOKS_DIR=$auth_dir run_podman 43 pull barfoo |
There was a problem hiding this comment.
Would you consider renaming the file, updating the header comments and test name, and renaming the $auth_dir variable? Otherwise future maintainers are going to be really lost.
There was a problem hiding this comment.
sure, renamed the script and its content.
giuseppe
force-pushed
the
rename-auth-scripts-to-preexec-hooks
branch
from
f42f827 to
8d8e80c
Compare
to not give a false sense of security since these are not a security mechanism but a hook to run arbitrary code before executing a command. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
rename-auth-scripts-to-preexec-hooks
branch
from
8d8e80c to
a581d2a
Compare
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to not give a false sense of security since these are not a security mechanism but a hook to run arbitrary code before executing a command.
Signed-off-by: Giuseppe Scrivano [email protected]
Does this PR introduce a user-facing change?