Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v4.4.0-RC1 #17094

Closed
wants to merge 2 commits into from
Closed

Bump to v4.4.0-RC1 #17094

wants to merge 2 commits into from

Conversation

ashley-cui
Copy link
Member

Cutting RC1 off main - no branch yet.
No release notes - to come in RC2.

None

@ashley-cui
Bump to v4.4.0-RC1
81b4835 
Signed-off-by: Ashley Cui <[email protected]>
@ashley-cui
Bump to v4.4.0-dev
f7bd6df 
Signed-off-by: Ashley Cui <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashley-cui
Copy link
Member Author

@mheon @containers/podman-maintainers PTAL

@Luap99
Copy link
Member

Luap99 commented Jan 12, 2023

Can we wait for #16732? This is needed for RHEL QE testing.
cc @TomSweeneyRedHat

@ashley-cui
Copy link
Member Author

@Luap99 sure, no problem!

@ashley-cui ashley-cui added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@mheon
Copy link
Member

mheon commented Jan 12, 2023

@ashley-cui You'll probably need to recreate the release PR after that merges, I've had issues with releases not including commits that were created after them but merged before.

@Luap99
Copy link
Member

Luap99 commented Jan 12, 2023

Yes a rebase will be required once that is merged

@ashley-cui
Copy link
Member Author

Alright, closing this PR and opening a new one after that merges.

@ashley-cui ashley-cui closed this Jan 12, 2023
@Luap99
Copy link
Member

Luap99 commented Jan 12, 2023

#16732 is merged

@ashley-cui
Copy link
Member Author

#17095

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashley-cui @Luap99 @mheon