-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logformatter: include base SHA, with history link #17056
logformatter: include base SHA, with history link #17056
Conversation
This is to help me in my flake analysis. Scenario: I'm looking at recent flakes, and see Flake X. I know that Flake X was "fixed" two weeks ago. Did the fix not work? Or is this just one of those PRs that was created three weeks ago (or three months ago) and never rebased to pick up the fix? This adds a one-click way for me to tell. Signed-off-by: Ed Santiago <[email protected]>
Would've loved to ci-colon-docs this to save cycles, but I need to confirm that it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yep, works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold I think I want to add a |
Never mind. There's no robust way to get the job-run time, only the time of processing the log. Which is available at bottom (signature) anyway. I think this is ready to go. /hold cancel |
/lgtm |
This is to help me in my flake analysis.
Scenario: I'm looking at recent flakes, and see Flake X. I know
that Flake X was "fixed" two weeks ago. Did the fix not work?
Or is this just one of those PRs that was created three weeks
ago (or three months ago) and never rebased to pick up the fix?
This adds a one-click way for me to tell.
Signed-off-by: Ed Santiago [email protected]