-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve symlink path for qemu directory if possible #17027
Conversation
3c9ae0e
to
cbddee8
Compare
Adding However, an analogous change may be useful for nix users of aarch64-linux -- I don't know, will experiment. |
@rhatdan -- it seems that @Luap99 thinks this PR belongs in podman, and I think it makes sense here as well (at least for now -- going forward, if similar issues pop up for other projects or architectures it could be adopted for them as well). As shown here, this patch seems to work well and would make a big difference for podman users on aarch64-darwin that are using nix (as opposed to homebrew) for package management, which I think is a growing group. I'm not sure what's going on with those test failures though. My only code change was in |
This is fine with me. |
@rhatdan thanks for your help and feedback with this issue. It looks like you're in the list of approvers. Is this blocked on anything else from my side? It looks like the CI failure is probably unrelated:
|
@n8henrie Can you please rebase? While it is not required we often have issues with older PRs that where not fully rebased on main. I will merge it then. |
Fixes containers#17026 Fixes NixOS/nixpkgs#169118 [NO NEW TESTS NEEDED] Related: NixOS/nixpkgs#163015 Signed-off-by: Nathan Henrie <[email protected]>
@Luap99 done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, n8henrie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@Luap99: once the present PR merges, I will cherry-pick it on top of v4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Luap99: new pull request created: #17429 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #17026
Fixes NixOS/nixpkgs#169118
Related: NixOS/nixpkgs#163015
Does this PR introduce a user-facing change?