-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Preprocess files in UTF-8 mode #17015
Conversation
Some (?) Python versions assume that text files are encoded as 7-bit ASCII and abort when encountering other encoding. Some of podman's markdown documentation files are encoded as UTF-8, and this needs to be specified explicitly when opening files. Closes containers#16996. [NO NEW TESTS NEEDED] Signed-off-by: Erik Schnetter <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eschnett, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The build failure seems to be
The message |
Yes, it's a flake, #16973. I've restarted it once already, I and/or others will keep restarting it until it passes. |
/lgtm Thanks, @eschnett . (for posterity: yes, python3 defaults to utf8 as it properly should, but it's possible for some environments to override that). |
Some (?) Python versions assume that text files are encoded as 7-bit ASCII and abort when encountering other encoding. Some of podman's markdown documentation files are encoded as UTF-8, and this needs to be specified explicitly when opening files.
Closes #16996.
[NO NEW TESTS NEEDED]
Signed-off-by: Erik Schnetter [email protected]
Does this PR introduce a user-facing change?
Additional comments
In principle one could add a CI test for this (by investigating which Python versions or setups fail or succeed, and by running a test with one of these versions). This seems quite tedious and likely not worth the effort.