Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Preprocess files in UTF-8 mode #17015

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

eschnett
Copy link
Contributor

@eschnett eschnett commented Jan 5, 2023

Some (?) Python versions assume that text files are encoded as 7-bit ASCII and abort when encountering other encoding. Some of podman's markdown documentation files are encoded as UTF-8, and this needs to be specified explicitly when opening files.

Closes #16996.

[NO NEW TESTS NEEDED]

Signed-off-by: Erik Schnetter [email protected]

Does this PR introduce a user-facing change?

None

Additional comments

In principle one could add a CI test for this (by investigating which Python versions or setups fail or succeed, and by running a test with one of these versions). This seems quite tedious and likely not worth the effort.

Some (?) Python versions assume that text files are encoded as 7-bit ASCII and abort when encountering other encoding. Some of podman's markdown documentation files are encoded as UTF-8, and this needs to be specified explicitly when opening files.

Closes containers#16996.

[NO NEW TESTS NEEDED]

Signed-off-by: Erik Schnetter <[email protected]>
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jan 5, 2023
@rhatdan rhatdan changed the title Preprocess files in UTF-8 mode [CI:DOCS] Preprocess files in UTF-8 mode Jan 5, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 5, 2023

/approve
LGTM
@edsantiago PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eschnett, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@eschnett
Copy link
Contributor Author

eschnett commented Jan 5, 2023

The build failure seems to be


Caching quay.io/libpod/cirros:latest at /tmp/quay.io-libpod-cirros-latest.tar...
Running: /var/tmp/go/src/github.com/containers/podman/bin/podman --root /tmp/root --runroot /tmp/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /tmp/root/etc/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp --events-backend file --storage-driver vfs pull quay.io/libpod/cirros:latest
Trying to pull quay.io/libpod/cirros:latest...
Error: copying system image from manifest list: parsing image configuration: Get "https://cdn03.quay.io/sha256/3c/3c82e4d066cf6f9e50efaead6e3ff7fddddf5527826afd68e5a969579fc4db4a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAI5LUAQGPZRPNKSJA%2F20230105%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230105T201344Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Signature=92cfa3b5023a1503994b7a117810aaa738cae50179d67e569d2a9c8a28a88ba3&cf_sign=Oa%2FqA0B79ORtWl%2Bxv4hoiO6gFrMdgiz5A3MGL%2FXTR8Oxw1713%2BmFM62%2FY7MYHUsv%2BGnuDlL9bXbO21aJOsvB%2F14qgjofmdC2g1SnQulXtTDp%2Ff2em8oPJecUXcB6fJzf4%2FVsZlw%2B1NK80Yp7N%2F6rAufXaP9%2FdRJ6JWfacbKPzbsnzBsDTvN%2FXZln%2BkP2AUwdIqiBbjISyOPtA9ZAq7TBNiOdLZkI8fVN31cFc9%2Bcai0hH2PJrvy3hq4N1irN6RbTssW3cWwFKFgsSjsNiBZON6TFd3WeIvk%2FZsirN%2B7xJdObrdOkzebFBkWr7FiVqL%2FOpuik%2FEc%2FDLTVReme0JJpmw%3D%3D&cf_expiry=1672950224&region=us-east-1": dial tcp: lookup cdn03.quay.io: no such host
Failure [1.123 seconds]

The message lookup cdn03.quay.io: no such host indicates a transient error that might go away if the CI pipeline is re-run.

@edsantiago
Copy link
Member

Yes, it's a flake, #16973. I've restarted it once already, I and/or others will keep restarting it until it passes.

@edsantiago
Copy link
Member

/lgtm

Thanks, @eschnett .

(for posterity: yes, python3 defaults to utf8 as it properly should, but it's possible for some environments to override that).

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 98d95f0 into containers:main Jan 5, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Python error while building podman from source
4 participants