-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes automated WSL installation on ARM #16997
Fixes automated WSL installation on ARM #16997
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
faaa922
to
85e2ec1
Compare
Fixes automated WSL installation on ARM Signed-off-by: Jason T. Greene <[email protected]>
85e2ec1
to
54afda2
Compare
LGTM |
/lgtm |
All PRs are failing CI today:
@n1hility could this be related, or is it just coincidence? |
@edsantiago i think this is unrelated. Will take a look, |
/cherry-pick v4.4 |
@baude: new pull request could not be created: failed to create pull request against containers/podman#v4.4 from head openshift-cherrypick-robot:cherry-pick-16997-to-v4.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between containers:v4.4 and openshift-cherrypick-robot:cherry-pick-16997-to-v4.4"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR builds on #16987, although the merge order does not matter, since it simply updates the installer.
This PR changes the custom action used to check the need for WSL installation to be a simple native C based win32 implementation as opposed to the cgo c-shared DLL approach used previously. This change is necessary to resolve compatibility problems with the Windows x86_64 emulation layer on ARM, which struggles with hot-loading a translated goruntime into an existing process (in contrast, standard executables and hard-linking work fine). Once this issue is resolved, this could be converted back to cgo for project consistency.
While the language has changed for the podman-msihooks.dll artifact, the existing process, pre-requisites, and build steps remain the same (cgo already required we had a win32 c compiler toolchain installed)
As mentioned in #16987, future PRs will update the installer to bundle arm64 podman remote client binaries. However, this is not necessary at this stage.
The installer itself, and it's supporting code will remain x86, even though it will eventually also package ARM binaries, for two reasons:
[NO NEW TESTS NEEDED]