Fix: List container with volume filter

[SamirPS]

Modify the condition in line 149 in order to list container by mounting point.

Closes #16019

Signed-off-by: SamirPS [email protected]

Does this PR introduce a user-facing change?

This PR only permit to fix the issue #16019

Fix: List container with volume filter

[mheon]

/approve

[mheon]

Should a test be added?

[SamirPS]

@Luap99 Should a test be added?

[rhatdan]

@SamirPS Please add a test.

[SamirPS]

@rhatdan Please tell me to what file I should add the test.

[rhatdan]

I would look at test/system/160-volumes.bats.

[SamirPS]

@rhatdan @mheon The test added is good or not?

[TomSweeneyRedHat]

LGTM
one of the tests was not happy, I've restarted as I suspect it to be a flake.

[SamirPS]

Okay, thanks for the information waiting for the merge then.

[rhatdan]

/lgtm
/hold

[SamirPS]

Oops i thinks i have wrongly done my squash

[vrothberg]

Oops i thinks i have wrongly done my squash

Yes, there's still a merge commit.

[SamirPS]

Yeah but when i squash this commit I have modified file :45

[vrothberg]

Yeah but when i squash this commit I have modified file :45

Try git pull --rebase $REMOTE/main. That should get rid of the merge commit.

[SamirPS]

@vrothberg Thanks for the command, it's good now?

[vrothberg]

/lgtm
/hold

Yes, there merge commit is gone now. Thank you!

[SamirPS]

Thanks you for the command! waiting for the test now

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, mheon, SamirPS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SamirPS]

@vrothberg @edsantiago @rhatdan Can I remove the SLASHhold or not ? I because the int remote fedora-27 failed because of the network test.

[edsantiago]

DO NOT REMOVE IT.

[edsantiago]

I'm sorry I wasn't clear. This is the rule: you can remove the hold only when tests go green. You cannot ever ever remove it otherwise.

The failure is a flake, it is rerunning. Once it goes green, I or someone else will remove the hold. Since it seems I can't explain properly, and there's a possibility of confusion, please do not touch anything for now. Thank you.

[SamirPS]

Okay sorry, i understand now

[edsantiago]

No problem. It's complicated and unintuitive. If you look at CI right now or in the next few minutes, you'll see that the flaking test has passed, but there are still a bunch more tests running. That's because CI is a cascade: certain tests will only run if their precursors pass. Here's a visualization. So now we still have another hour or so to wait to see if CI goes green.

Anyhow, the critical thing to remember is: CI must be green in order to merge.

[SamirPS]

All green right now

[edsantiago]

Indeed!

/hold cancel

Thank you @SamirPS !