Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: support "die" filter #16912

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Dec 21, 2022

Map "die" to the "died" status for Docker compat.

Fixes: #16857
Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

Podman now supports "die" as a filter value for events for Docker compatibility (mapping to "died") .

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2022
@vrothberg vrothberg marked this pull request as ready for review December 21, 2022 13:09
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

@vrothberg vrothberg force-pushed the fix-16875 branch 3 times, most recently from 3bf715b to a715068 Compare December 21, 2022 13:31
@baude
Copy link
Member

baude commented Dec 21, 2022

man page update? else, LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 21, 2022

LGTM

Map "die" to the "died" status for Docker compat.

Fixes: containers#16857
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

Massaged the docs a bit ✔️

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2022

The

  • 337 podman system connection - tcp
    test is breaking all the time.

@vrothberg
Copy link
Member Author

Green. Ready to go.

@vrothberg
Copy link
Member Author

The

* 337 podman system connection - tcp
  test is breaking all the time.

@cdoern is working on that in #16916.

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2a46b5e into containers:main Dec 22, 2022
@vrothberg vrothberg deleted the fix-16875 branch December 22, 2022 13:00
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

events API docker compatibility issue
4 participants