-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hostPath and configMap subpath usage #16887
Conversation
405aa5f
to
985080e
Compare
podman play kube now supports and has tests for the subpath field when using a hostPath volume type and a configMap volume type. The hostpath works similarly to the named volume, allowing a user to specify a whole directory but also a specific file or subdir within that mount. Config Maps operate the same way but specifically allow users to mount specific data in a subpath alongside the existing data resolves containers#16828 Signed-off-by: Charlie Doern <[email protected]>
@containers/podman-maintainers PTAL, something seems to be wrong with kube generation where host path volumes render the entire FS inaccessible on CI. These tests work normally on my machines but fail here except for the containerized tests. |
LGTM |
@umohnani8 PTAL |
@cdoern the tests look happy now, were you running into issue elsewhere? The changes look reasonable to me, but I'd like a head nod from @umohnani8 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
podman play kube now supports and has tests for the subpath field when using a hostPath volume type and a configMap volume type. The hostpath works similarly to the named volume, allowing a user to specify a whole directory but also a specific file or subdir within that mount. Config Maps operate the same way but specifically allow users to mount specific data in a subpath alongside the existing data
resolves #16828
Signed-off-by: Charlie Doern [email protected]
Does this PR introduce a user-facing change?