Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hostPath and configMap subpath usage #16887

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Dec 19, 2022

podman play kube now supports and has tests for the subpath field when using a hostPath volume type and a configMap volume type. The hostpath works similarly to the named volume, allowing a user to specify a whole directory but also a specific file or subdir within that mount. Config Maps operate the same way but specifically allow users to mount specific data in a subpath alongside the existing data

resolves #16828

Signed-off-by: Charlie Doern [email protected]

Does this PR introduce a user-facing change?

podman play kube can now handle subpaths when using configmap and hostpath volume types

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Dec 19, 2022
@cdoern cdoern force-pushed the subpath branch 7 times, most recently from 405aa5f to 985080e Compare December 20, 2022 02:57
podman play kube now supports and has tests for the subpath field when using a hostPath volume type and a configMap volume type.
The hostpath works similarly to the named volume, allowing a user to specify a whole directory but also a specific file or subdir within that mount. Config Maps operate the same way but specifically allow users to mount specific data in a subpath alongside the existing data

resolves containers#16828

Signed-off-by: Charlie Doern <[email protected]>
@cdoern
Copy link
Contributor Author

cdoern commented Dec 20, 2022

@containers/podman-maintainers PTAL, something seems to be wrong with kube generation where host path volumes render the entire FS inaccessible on CI. These tests work normally on my machines but fail here except for the containerized tests.

@rhatdan
Copy link
Member

rhatdan commented Dec 20, 2022

LGTM
@containers/podman-desktop-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Dec 20, 2022

@mheon Any ideas on @cdoern comment?

@rhatdan
Copy link
Member

rhatdan commented Dec 21, 2022

@umohnani8 PTAL

@TomSweeneyRedHat
Copy link
Member

@cdoern the tests look happy now, were you running into issue elsewhere? The changes look reasonable to me, but I'd like a head nod from @umohnani8

@umohnani8
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 535d4d4 into containers:main Jan 3, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support subpath with HostPath volume mount
5 participants