Allow '/' to prefix container names to match Docker

[rhatdan]

Fixes: #16663

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

Podman now supports container names beginning with a '/' to match Docker behaviour.

[vrothberg]

I think there's more to unpack since Docker strips off the leading '/'. '/foo' create the name "foo" and it will also be stripped of in regexes. Yet ^/foo$ is not a valid regex to me.

[Luap99]

I think there's more to unpack since Docker strips off the leading '/'. '/foo' create the name "foo" and it will also be stripped of in regexes. Yet ^/foo$ is not a valid regex to me.

docker always stores the name with a leading /, if you look at the API response they always include the slash. see the compat API for example

podman/pkg/api/handlers/compat/containers.go

Line 497 in 1b677c5

Name: fmt.Sprintf("/%s", l.Name()),

So if you apply a filter via docker api we must also add the slash to the name before running the filter regex.

[mheon]

Can initialize this with make([]string, 0, len(input)) to ensure we only do one allocation

[rhatdan]

@vrothberg @Luap99 @mheon PTAL

[mheon]

Code LGTM

[rhatdan]

@containers/podman-maintainers PTAL

[rhatdan]

@vrothberg @giuseppe @flouthoc @ashley-cui PTAL

[flouthoc]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

/cherry-pick v4.4

[openshift-cherrypick-robot]

@baude: #16820 failed to apply on top of branch "v4.4":

Applying: Allow '/' to prefix container names to match Docker
Using index info to reconstruct a base tree...
M	cmd/podman/containers/attach.go
M	cmd/podman/containers/checkpoint.go
M	cmd/podman/containers/commit.go
M	cmd/podman/containers/exec.go
M	cmd/podman/containers/exists.go
M	cmd/podman/containers/export.go
M	cmd/podman/containers/init.go
M	cmd/podman/containers/kill.go
M	cmd/podman/containers/logs.go
M	cmd/podman/containers/mount.go
M	cmd/podman/containers/pause.go
M	cmd/podman/containers/port.go
M	cmd/podman/containers/prune.go
M	cmd/podman/containers/rename.go
M	cmd/podman/containers/restart.go
M	cmd/podman/containers/restore.go
M	cmd/podman/containers/rm.go
M	cmd/podman/containers/runlabel.go
M	cmd/podman/containers/start.go
M	cmd/podman/containers/stats.go
M	cmd/podman/containers/stop.go
M	cmd/podman/containers/top.go
M	cmd/podman/containers/unmount.go
M	cmd/podman/containers/unpause.go
M	cmd/podman/containers/update.go
M	cmd/podman/containers/wait.go
M	cmd/podman/utils/utils.go
M	libpod/options.go
M	libpod/runtime_ctr.go
M	pkg/domain/filters/containers.go
M	test/system/030-run.bats
Falling back to patching base and 3-way merge...
Auto-merging test/system/030-run.bats
CONFLICT (content): Merge conflict in test/system/030-run.bats
Auto-merging pkg/domain/filters/containers.go
Auto-merging libpod/runtime_ctr.go
Auto-merging libpod/options.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow '/' to prefix container names to match Docker
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrothberg]

This is already in the v4.4 branch