Add gvproxy to windows packages

[arixmkii]

This adds gvproxy.exe (which is a requirement to use podman with Qemu on windows(#13006)) to Windows installers and zip builds.

Included changes:

• commit hash reference of gvisor-tap-vsock is bumped to latest (to include unix domain socket support on Windows); (was fixed already in upstream)
• wih-sshproxy build step is renamed to gvproxy (to match the repository name);
• gvproxy build step is responsible for both artifacts - win-sshproxy.exe and gvproxy.exe;
• gvproxy.exe added to zip archive;
• gvproxy.exe added to msi build;
• gvproxy.exe added to new Windows installer (unfortunately there is no fallback options as with win-sshproxy.exe, so, for packaging older versions - older version of script will be required);
• fixes for building on Windows with msys2:
  • GOROOT is passed to go executable for host detection (as msys packages cine with GOROOT override), this assumed to be safe for other builds;
  • utf-8 encoding is enforced in python script; (was fixed already in upstream)
  • unix style line endings are enforced in python script;
  • added workaround with unlinking file before renaming in python script (as renaming behaves differently on Windows, when file exists);
  • removed explicit -in /dev/stdin from go-md2man as this a default (reads StdIn if not specified) and this triggers some regression in msys2 with latest updates.

This is extracted from my work on Qemu Podman Machine on Windows. It might look that there is no value in adding binary in advance, but I could challenge this with the statement, that it will be possible to launch gvproxy and Qemu VM manually and then setup podman remote connection to use it in a machine like scenario (without handy helpers of podman machine). If this can't be accepted int his form, I can move it to draft and add the description of this scenario to https://github.com/containers/podman/tree/main/docs/tutorials

Signed-off-by: Arthur Sengileyev [email protected]

Does this PR introduce a user-facing change?

gvproxy.exe added to Windows installers

[arixmkii]

Added documentation how to setup QEMU machine with gvproxy and use it with podman.

[arixmkii]

Squashed commits. Added one more change - removed explicit "-in /dev/stdin" from go-md2man because there is a regression in how msys2 handles this input after some updates.

 open /proc/self/fd/0: The system cannot find the path specified.

Update: had to rebase to upstream head.

[arixmkii]

It is not forgotten. Will update the PR this week.

[arixmkii]

Rebased. Description updates (as some fixes were already applied upstream).

@TomSweeneyRedHat I addressed the issues you pointed out in a separate commit. Taking into account amount feedback you contributed, should I mention you in Co-authored-by: section for that commit (I could not just accept suggestions, because I needed to rebase the code first)?

[arixmkii]

gvproxy team promised to upload latest artifacts to the releases page. I will then update the section removing gvproxy build instructions and replace it with a link.

Update: added the link and description to the latest commit.

[arixmkii]

I'm leaning towards adding [NO NEW TESTS NEEDED] if there no tests, which validates the content of Zip or exe artifacts.

[rhatdan]

SGTM, add no new test needed.

[rhatdan]

@n1hility PTAL

[n1hility]

Looks good but have some suggestions here, mostly around docs. We were likely to include gvproxy.exe anyway for a future user-space network so this is a bit serendipitous!

[arixmkii]

Updated tutorial, rebased to latest main and squashed commits.

Changes:

• applied recommended changes in tutorial;
• reworked and simplified Introduction section;
• updated Makefile.

@n1hility kept the changes since latest version as a separate commit in a different branch arixmkii@f785459 for your convenience doing the review.

[n1hility]

/approve LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, n1hility

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [n1hility]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

/lgtm

[rhatdan]

/cherry-pick v4.4

[openshift-cherrypick-robot]

@rhatdan: new pull request created: #17275

In response to this:

/cherry-pick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.