add support for subpath in play kube for named volumes #16803
Conversation
cdoern
force-pushed
the
subpath
branch
2 times, most recently
from
2b098ca to
eade91e
Compare
|
@vrothberg @umohnani8 @mheon PTAL |
| @@ -254,6 +254,8 @@ type ContainerNamedVolume struct { | |||
| // IsAnonymous sets the named volume as anonymous even if it has a name | |||
| // This is used for emptyDir volumes from a kube yaml | |||
| IsAnonymous bool `json:"setAnonymous,omitempty"` | |||
| // SubPath determines which part of the Source will be mounted in the container | |||
| SubPath string | |||
There was a problem hiding this comment.
Does this need to be stored? Or is this only in effect for the length of the kube play? Not sure this needs to be plumbed this deeply?
There was a problem hiding this comment.
I think it does since in generateSpec (which play kube eventually calls) we use ContainerNamedVolume to generate the mountpoint and we need to subpath to get the source properly.
There was a problem hiding this comment.
Shouldn't we just put the full path (path + subpath) into the named volume as Path?
There was a problem hiding this comment.
Oh, wait, I see the problem there, different containers will want to index into the volume at different places.
subpath allows for only a subdirecty of a volumes data to be mounted in the container add support for the named volume type sub path with others to follow. resolves containers#12929 Signed-off-by: Charlie Doern <[email protected]>
| - sleep | ||
| - inf | ||
| volumeMounts: | ||
| - mountPath: /var |
There was a problem hiding this comment.
Does this work with other types of volume mount? HostPath for example?
There was a problem hiding this comment.
Not in this PR, probably won't be too hard though. I think I just need to edit all of the appropriate specgen structs.
|
Should we expose Subpath via |
I agree, but should it be a separate PR? |
|
OK, separate PR is fine. Maybe make a GH issue so we don't forget about it? Code LGTM |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
subpath allows for only a subdirecty of a volumes data to be mounted in the container add support for the named volume type sub path with others to follow.
resolves #12929
Signed-off-by: Charlie Doern [email protected]
Does this PR introduce a user-facing change?