Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote: allow --http-proxy for remote clients #16776

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 7, 2022

The remote client should be allowed to specify if the container should be run with the proxy env vars. It will still use the proxy vars from the server process and not the client. This makes podman-remote more consistent with the local version and easier to use in environments where a proxy is required.

Fixes #16520

Does this PR introduce a user-facing change?

podman-remote build set `--http-proxy` to true by default to match the other commands.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@Luap99
Copy link
Member Author

Luap99 commented Dec 7, 2022

@sstosh PTAL since you changed some test with that recently.

@rhatdan
Copy link
Member

rhatdan commented Dec 7, 2022

LGTM

@sstosh
Copy link
Contributor

sstosh commented Dec 8, 2022

The remote client should be allowed to specify if the container should
be run with the proxy env vars. It will still use the proxy vars from
the server process and not the client. This makes podman-remote more
consistent with the local version and easier to use in environments
where a proxy is required.

Fixes containers#16520

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
Copy link
Member Author

Luap99 commented Dec 8, 2022

@sstosh Thanks, I changed those two as well.

@rhatdan
Copy link
Member

rhatdan commented Dec 9, 2022

@flouthoc @giuseppe @vrothberg PTAL
@containers/podman-maintainers PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 859f40a into containers:main Dec 9, 2022
@Luap99 Luap99 deleted the http-proxy branch December 9, 2022 10:41
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman build http_proxy=false for remote client causes issues when using the api
5 participants