Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network create: support "-o parent=XXX" for ipvlan #16747

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 5, 2022

Just like macvlan the ipvlan driver accepts a specific parent interface.

Fixes #16621

Does this PR introduce a user-facing change?

Accept the `--opt parent=...` option  in podman network create with the ipvlan network driver.

Just like macvlan the ipvlan driver accepts a specific parent interface.

Fixes containers#16621

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@mheon
Copy link
Member

mheon commented Dec 5, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 5, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@Luap99
Copy link
Member Author

Luap99 commented Dec 6, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7cdf376 into containers:main Dec 6, 2022
@Luap99 Luap99 deleted the ipvlan-parent branch December 6, 2022 15:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error: unsupported network option parent" for ipvlan driver (using CNI)
4 participants