[CI:DOCS] Clarify secret target behavior #16743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mheon
reviewed
Dec 5, 2022
ashley-cui
force-pushed
the
secdocs
branch
2 times, most recently
from
9ac5ca5 to
444c41a
Compare
mheon
reviewed
Dec 5, 2022
| - `uid=0` : UID of secret. Defaults to 0. Mount secret type only. | ||
| - `gid=0` : GID of secret. Defaults to 0. Mount secret type only. | ||
| - `mode=0` : Mode of secret. Defaults to 0444. Mount secret type only. | ||
|
|
||
|
|
||
| Examples |
There was a problem hiding this comment.
Usually we do a ## before this, and surround individual examples with triple-backticks
There was a problem hiding this comment.
Changed the triple backticks! I think this is under a #### section for in a flag doc though, so I think leaving Examples as-is might be the move?
|
@containers/podman-maintainers PTAL |
vrothberg
reviewed
Dec 9, 2022
Add documentation on how the the target option works when adding a secret to a container Signed-off-by: Ashley Cui <[email protected]>
|
@containers/podman-maintainers PTAL |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation on how the the target option works when adding a secret to a container
Signed-off-by: Ashley Cui [email protected]
Closes: #16649
Does this PR introduce a user-facing change?