-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a FreeBSD cross build to the cirrus alt build task #16723
Conversation
This just verifies that a non-cgo podman binary can build for FreeBSD. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
LGTM. @dfr are you interested in the built binary being added to the artifacts archive? That will get you a permalink to download the continuously built binary from |
I was looking at the podman-release target which I think is the one that builds this? I think that building this correctly will mean adding a FreeBSD VM to the CI setup similar to OSX Cross since there are a few dependencies that don't support CGO - gpgme comes to mind but there may be others. Rather than take that step, I opted for the lower-cost cross build. If it seems reasonable though I can put together a freebsd_alt_build_task - cirrus already supports FreeBSD VMs. |
Sure if you have a mind to. I'd prefer GCP to AWS. Our standard (I'd do it myself, save for knowing nothing about FreeBSD) |
This just verifies that a non-cgo podman binary can build for FreeBSD.
[NO NEW TESTS NEEDED]
Signed-off-by: Doug Rabson [email protected]
Does this PR introduce a user-facing change?