Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FreeBSD cross build to the cirrus alt build task #16723

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Dec 3, 2022

This just verifies that a non-cgo podman binary can build for FreeBSD.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson [email protected]

Does this PR introduce a user-facing change?

None

This just verifies that a non-cgo podman binary can build for FreeBSD.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Dec 4, 2022

LGTM
@cevich PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@rhatdan
Copy link
Member

rhatdan commented Dec 5, 2022

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Dec 5, 2022

LGTM
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit b825ea7 into containers:main Dec 5, 2022
@cevich
Copy link
Member

cevich commented Dec 5, 2022

LGTM.

@dfr are you interested in the built binary being added to the artifacts archive? That will get you a permalink to download the continuously built binary from main and any new release branches. Not sure if that's useful to you or not.

@dfr
Copy link
Contributor Author

dfr commented Dec 5, 2022

LGTM.

@dfr are you interested in the built binary being added to the artifacts archive? That will get you a permalink to download the continuously built binary from main and any new release branches. Not sure if that's useful to you or not.

I was looking at the podman-release target which I think is the one that builds this? I think that building this correctly will mean adding a FreeBSD VM to the CI setup similar to OSX Cross since there are a few dependencies that don't support CGO - gpgme comes to mind but there may be others. Rather than take that step, I opted for the lower-cost cross build.

If it seems reasonable though I can put together a freebsd_alt_build_task - cirrus already supports FreeBSD VMs.

@cevich
Copy link
Member

cevich commented Dec 6, 2022

If it seems reasonable though I can put together a freebsd_alt_build_task - cirrus already supports FreeBSD VMs.

Sure if you have a mind to. I'd prefer GCP to AWS. Our standard ./contrib/cirrus/* scripts will be unlikely to work right/at-all since they expect specially crafted VMs. But if you can figure out how to do a runtime setup, I can translate that into our pre-built CI VM image workflow.

(I'd do it myself, save for knowing nothing about FreeBSD)

@dfr dfr deleted the freebsd-cross branch December 13, 2022 15:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants