Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for --init-ctr #16722

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 3, 2022

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

--init-ctr completions now work.

[NO NEW TESTS NEEDED] Since I don't know how to test completions.

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Dec 3, 2022

@Luap99 Is there any way to test completions?

@Luap99
Copy link
Member

Luap99 commented Dec 3, 2022

@Luap99 Is there any way to test completions?

Depends, we test argument completion in test/system/600-completion.bats but this is only for things like image or container names that we know exist. We also test that all options and commands have a completion function set in cmd/podman/shell_completion_test.go

We do not test for simple flag values like this PR implements and I don't see a strong reason to do it.

Signed-off-by: Daniel J Walsh <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I love to see others improving the shell completion :)

@Luap99
Copy link
Member

Luap99 commented Dec 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit f223bba into containers:main Dec 5, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants