-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion for --init-ctr #16722
Conversation
@Luap99 Is there any way to test completions? |
Depends, we test argument completion in test/system/600-completion.bats but this is only for things like image or container names that we know exist. We also test that all options and commands have a completion function set in cmd/podman/shell_completion_test.go We do not test for simple flag values like this PR implements and I don't see a strong reason to do it. |
Signed-off-by: Daniel J Walsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I love to see others improving the shell completion :)
/lgtm |
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?
[NO NEW TESTS NEEDED] Since I don't know how to test completions.