Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:BUILD] Makefile: Use CGO when building natively on MacOS. #16690

Closed
wants to merge 1 commit into from
Closed

[CI:BUILD] Makefile: Use CGO when building natively on MacOS. #16690

wants to merge 1 commit into from

Conversation

ashley-cui
Copy link
Member

Fix a regression (DNS not resolvable) caused by not setting CGO correctly in the Makefile while building podman-remote on OSX. See golang/go#12524 for details.

Signed-off-by: Ashley Cui [email protected]

Fixes: #16230

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@ashley-cui
Copy link
Member Author

Ugh, something's gone wrong.. hang tight

@ashley-cui ashley-cui added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
@ashley-cui
Copy link
Member Author

ashley-cui commented Dec 1, 2022 •
edited
Loading

Hm, so it looks like this builds correctly on my machine, @cevich do you have any idea why building it in CI would be any different? (CGO failing to find a file)

@cevich
Copy link
Member

cevich commented Dec 1, 2022

Unf. I really don't know much about this level of wizardry. My version of "help" would likely be "press all the buttons until it works or goes boom".

I looked at the "CGO must be disabled" comment-link, but it doesn't make sense to me. But I seem to remember this was a hard-rule: no CGO for podman-remote on Mac. But this might be a question for @mheon or @vrothberg

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jan 3, 2023

@ashley-cui what is going on with this PR?

@ashley-cui
Copy link
Member Author

Running into "builds on my machine but not in CI". I'll pick this up again.

@rhatdan rhatdan removed the stale-pr label Jan 3, 2023
@ashley-cui ashley-cui force-pushed the darwincgo branch 2 times, most recently from 37d4aa8 to ebc04f7 Compare January 19, 2023 19:01
@ashley-cui ashley-cui changed the title Makefile: Use CGO when building natively on MacOS. [CI:BUILD] Makefile: Use CGO when building natively on MacOS. Jan 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2023
@ashley-cui ashley-cui added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2023
@ashley-cui ashley-cui marked this pull request as draft January 19, 2023 19:05
@ashley-cui
Copy link
Member Author

This is extraordinarily frustrating, since this builds correctly on my machine. Testing out a different cirrus image and seeing if that changes anything..

@ashley-cui
[CI:BUILD] Makefile: Use CGO when building natively on MacOS.
026667a 
Testing Cirrus as well because it works on my machine
Fix a DNS regression caused by not setting CGO correctly in the makefile while building podman-remote on OSX.

Signed-off-by: Ashley Cui <[email protected]>
@cevich
Copy link
Member

cevich commented Jan 19, 2023

This is extraordinarily frustrating, since this builds correctly on my machine.

I hear ya. Fail-repeat-FAIL-repeat-FaIl-rePEAT! gets exhausting quickly. But if it's even fixable, you're the one to figure it out. I'm both a fool and completely ignorant when it comes to Mac stuffs 😞

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan rhatdan removed the stale-pr label Feb 21, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 21, 2023

@ashley-cui @cevich any update on this?

@ashley-cui
Copy link
Member Author

Can't make it run in CI for some reason, but it builds on my mac. Might try a workaround by setting the env var in brew instead of here, will try to pick it up again soon

@vrothberg
Copy link
Member

Friendly ping, @ashley-cui.

@ashley-cui
Copy link
Member Author

I think this needs more massaging, closing for now and will pick it up with a different perspective later.

@ashley-cui ashley-cui closed this Apr 4, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
@ashley-cui ashley-cui deleted the darwincgo branch September 28, 2023 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSX DNS ignored for login
4 participants
@ashley-cui @cevich @rhatdan @vrothberg