fix an override logic in Inherit function #16668
Conversation
|
LGTM, could you add a test? |
|
@karta0807913 Either add a test or [NO NEW TESTS NEEDED] to the message above and then force push so we can merge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karta0807913, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Sure, give me some time to figure out how to add a test :D |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
Fix an overriding logic in Inhearit function. Alos, ToSpecGen function doesn't load the cgroup/image volume config from containers.conf. Signed-off-by: karta0807913 <[email protected]>
Signed-off-by: karta0807913 <[email protected]>
| } | ||
| if s.ImageVolumeMode == "bind" { | ||
| s.ImageVolumeMode = "anonymous" | ||
| } |
There was a problem hiding this comment.
@giuseppe could you check the logic here?
I copy them from the fill spec function.
Signed-off-by: karta0807913 <[email protected]>
|
HI @rhatdan, I fix all tests. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: karta0807913 [email protected]
Refer to issue #16632
Does this PR introduce a user-facing change?
No