Run codespell on code #16651
Run codespell on code #16651
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
test/system/015-help.bats
Outdated
| @@ -136,7 +136,7 @@ function check_help() { | |||
| run_podman '?' "$@" $cmd </dev/null | |||
| is "$status" 125 \ | |||
| "'$usage' indicates at least one required arg. I invoked it with no args and expected an error exit code" | |||
| is "$output" "Error:.* \(require\|specif\|must\|provide\|need\|choose\|accepts\)" \ | |||
| is "$output" "Error:.* \(require\|specify\|must\|provide\|need\|choose\|accepts\)" \ | |||
There was a problem hiding this comment.
This one needs to revert: error messages can be "specify", "specified", or other possibilities.
There was a problem hiding this comment.
/me thinks you forgot to revert this. Tests are gonna fail again.
|
If you run these so often I wonder why do we not put this into a CI check? |
|
My guess is, because the false-positive rate is too high. I suspect Dan only commits one out of every 4-5 "errors" reported by the spellcheck tool. |
|
No over time it has gotten much better. so we might want to do it automatically. |
|
This runs with a clean |
Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?