Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpod: Add checks to avoid nil pointer dereference if network setup fails #16645

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Nov 28, 2022

This addresses #16333 although that issue was also avoided by changes in PR #16554.

Signed-off-by: Doug Rabson [email protected]

None

@dfr dfr force-pushed the freebsd-nil-pointers branch 2 times, most recently from ea85136 to b82ed76 Compare November 28, 2022 12:59
@dfr dfr changed the title libpod: Add checks to avoid nil pointer derefere if network setup fails libpod: Add checks to avoid nil pointer dereference if network setup fails Nov 28, 2022
…fails

This addresses containers#16333 although that issue was also avoided by changes in
PR containers#16554.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <[email protected]>
@dfr dfr force-pushed the freebsd-nil-pointers branch from b82ed76 to 0794076 Compare November 28, 2022 13:10
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@baude
Copy link
Member

baude commented Nov 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 50992d0 into containers:main Nov 28, 2022
@dfr dfr deleted the freebsd-nil-pointers branch November 29, 2022 15:55
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants