Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vendor of containers/(common, image, buildah) #16639

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Update Vendor of containers/(common, image, buildah) #16639

merged 1 commit into from
Nov 28, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 27, 2022 •
edited
Loading

Signed-off-by: Daniel J Walsh [email protected]

Does this PR introduce a user-facing change?

Should see a speedup by removing an extra conmon exec.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Nov 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 27, 2022
@rhatdan rhatdan added bloat_approved Approve a PR in which binary file size grows by over 50k and removed bloat_approved Approve a PR in which binary file size grows by over 50k labels Nov 28, 2022
@rhatdan rhatdan added the bloat_approved Approve a PR in which binary file size grows by over 50k label Nov 28, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Nov 28, 2022

@alexlarsson PTAL

@mheon
Copy link
Member

mheon commented Nov 28, 2022

LGTM, but you have test failures

vrothberg
vrothberg reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 935c8eb into containers:main Nov 28, 2022
@edsantiago edsantiago mentioned this pull request Dec 5, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhatdan @mheon @vrothberg @openshift-merge-robot