Kube Play: fix the handling of the optional field of SecretVolumeSource #16637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
force-pushed
the
secret_volume
branch
from
17585f7 to
062ebbc
Compare
|
@vrothberg I've already started working on them. I'll add them to the PR later today |
ygalblum
force-pushed
the
secret_volume
branch
from
062ebbc to
1ca8513
Compare
|
Looks like this needs to be gofmt |
|
LGTM |
ygalblum
force-pushed
the
secret_volume
branch
from
1ca8513 to
8148c0e
Compare
openshift-merge-robot
added
the
needs-rebase
If the secret exists, set optional in the KubeVolume to false to always use it If the secret does not exist, if optional, set the same in the KubeVolume to skip it, otherwise fail Add e2e tests Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
secret_volume
branch
from
8148c0e to
9a6b701
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
@rhatdan All tests passed, waiting for you to remove the hold |
|
@ygalblum You can remove the hold yourself, with |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the secret exists, set optional in the KubeVolume to false to always use it
If the secret does not exist, if optional, set the same in the KubeVolume to skip it, otherwise fail
Signed-off-by: Ygal Blum [email protected]
Does this PR introduce a user-facing change?
No
Fixes #16636