add support for --ssh=native in podman-remote

[cdoern]

podman's new global flag --sah=native only works with scp and system connection add at the moment modify this so that --ssh=native can be used with podman-remote. This means users can plug in their custom ssh config and known_host files.

Signed-off-by: Charlie Doern [email protected]

Does this PR introduce a user-facing change?

add support for --ssh=native in all podman-remote use cases

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cdoern
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval by writing /assign @mheon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdoern]

@cevich, this is failing when I try to cp /etc/ssh/sshd_config filepath.Join(u.HomeDir, ".ssh", "config") with no output or error but only fails rootless. Is there a chance user.Current() when rootless does not have a home dir?

[cevich]

cp /etc/ssh/sshd_config filepath.Join(u.HomeDir, ".ssh", "config")

👀 you sure that's not suppose to be /etc/ssh/ssh_config? 👀

only fails rootless. Is there a chance user.Current() when rootless does not have a home dir?

Yes actually. Well actually, it depends on how the call-stack was setup. If it originated with an ssh rootlessuser@localhost then $HOME should most certainly be defined. If otherwise, then there's a chance $HOME is not setup or exported properly, or (gasp) set to the wrong value (like /root/).

There's a hack in place to try and ensure this can't happen. But it's entirely possible that's not working as intended for your use-case. Analysis of the call-stack is likely necessary. But as a first-step, is there a dummy-way of printing out $HOME from your code and/or u.HomeDir?

[cdoern]

@cevich both ssh_config and sshd_config should exist and sshd_config is the right one. However, I'll add some debugs and repush.

[cdoern]

@cevich PTAL at this one when you get a chance, integration tests keep failing in setup due to my ssh dir changes

[cdoern]

@containers/podman-maintainers PTAL, the aarch tests keep failing on different tests each time I re-run them...

[openshift-merge-robot]

@cdoern: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[rhatdan]

@Luap99 Any chance you could take this over?

[Luap99]

Unlikely, I am not sure what is needed here?

[vrothberg]

I think a rebase should fix the aarch flakes.

@cdoern is there anything else needed?