Update the issue templates #16572

mohanboddu · 2022-11-21T16:02:50Z

Adding "Bug Report" and "Feature Request" templates, this will help with filing the tickets and also finding the information once filed.

Signed-off-by: Mohan Boddu [email protected]

Does this PR introduce a user-facing change?

None

.github/ISSUE_TEMPLATE/bug_report.yaml

Luap99 · 2022-11-21T16:35:25Z

@mohanboddu Can you enable this on your fork so I could test it there? I much rather try it than looking at yaml.

Luap99

Most of the requested dropdown selections are already visible podman info. If I fill a bug I don't want to provide the same info twice.
Would it be possible to let users paste in podman info and only if podman info is not working (e.g. on macos with broken machine) asking the questions?

Luap99 · 2022-11-21T17:01:01Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+
+        Also, there is a running list of known issues in the [Podman Troubleshooting Guide](https://github.com/containers/podman/blob/main/troubleshooting.md), please reference that page before opening a new issue.
+
+        If you are filing a bug against `podman build`, please instead file a bug against Buildah (https://github.com/containers/buildah/issues). Podman build executes Buildah to perform container builds, and as such the Buildah maintainers are best equipped to handle these bugs.


Honestly I am not even sure if this is still true. A lot of bugs are related to podman-remote build which must also be fixed in podman.
We can move the issue over to the buildah repo if it has to be fixed there, in the podman repo we get at least more eyeballs on new issues.

True, I think podman build bugs should be manually triaged to buildah if its needed, in most cases its compat API or podman-remote build which is indeed a podman issue.

Luap99 · 2022-11-21T17:02:41Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+        - 3.4
+        - 3.3
+        - 3.2
+        - 3.1
+        - 3.0


I wouldn't even offer 3.X versions. We have no plans of supporting them. People should verify their bugs against the latest versions.

Luap99 · 2022-11-21T17:09:19Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+    id: upstream_latest
+    attributes:
+      label: Upstream Latest Release
+      description: Have you tried running the [latest upstream release](https://github.com/containers/podman/releases/latest)


NOTE, this link does not actually point to the latest release following semver. It chooses the latest release by date so it could link to outdated versions when we do backport releases.

We can use https://github.blog/changelog/2022-10-21-explicitly-set-the-latest-release/ to mark the latest release, might require some work from @mheon based on how he is cutting the release and if it is useful in general.

#16696 should solve this issue as well

edsantiago

I like the split between bug and feature. I don't like all the new structure. For bugs, we really should insist on podman info output: it is both easier and more reliable than anything entered by a human.

edsantiago · 2022-11-21T17:57:29Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+name: Bug Report
+description: File a bug report
+title: "[Bug]: "
+labels: ["bug", "triage"]


Should that be kind/bug?

And, the triage label does not exist. This is a good opportunity to decide if that's the best name, or it should be triage-needed or something else. (Also, it's not clear to me what is meant here by "triage". Assign to someone? Sub-categorize?)

Fixed the kind/bug part, updated triage to traige-needed for now.

edsantiago · 2022-11-21T17:59:19Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+      value: |
+        Thanks for taking the time to fill out this bug report!


In the current template, this is all inside HTML comments. That minimizes clutter. Does this "attributes" thing also guarantee that the new template will have this cruft in comments?

Yes, its all part of HTML page rather than part of the form

edsantiago · 2022-11-21T18:02:11Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+      options:
+        - main


Clicky-stuff is pretty at first glance, but a hindrance to experts. This list will be Yet Another Thing to be hand-maintained over time, and it's likely not to even be useful because people will likely fill it in inconsistently. Can we nuke it?

I am also in favor of nuking.

podman info shows that information

edsantiago · 2022-11-21T18:04:04Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+    id: os
+    attributes:
+      label: Operating System 
+      description: What operating system are you using?


This, too, is in podman info. I don't see how this is a useful addition to our template.

I am also in favor of nuking.

podman info shows that information

It's not listing Debian and OpenSUSE, for instance, but puts all RH distros first.

.github/ISSUE_TEMPLATE/feature_request.yaml

mohanboddu · 2022-11-21T22:06:38Z

Most of the requested dropdown selections are already visible podman info. If I fill a bug I don't want to provide the same info twice. Would it be possible to let users paste in podman info and only if podman info is not working (e.g. on macos with broken machine) asking the questions?

Clicky-stuff is pretty at first glance, but a hindrance to experts. This list will be Yet Another Thing to be hand-maintained over time, and it's likely not to even be useful because people will likely fill it in inconsistently. Can we nuke it?

@Luap99 @edsantiago I hear your concerns, lets discuss in the next meeting and will make the changes as per the discussion.

mohanboddu · 2022-11-21T22:25:17Z

@mohanboddu Can you enable this on your fork so I could test it there? I much rather try it than looking at yaml.

In the current template, this is all inside HTML comments. That minimizes clutter. Does this "attributes" thing also guarantee that the new template will have this cruft in comments?

@Luap99 @edsantiago please take a look at https://github.com/mohanboddu/podman/issues/new/choose, I hope this helps to clear some of your questions

vrothberg

I would love to test this first.

I am afraid there are too many questions that would personally annoy me a lot. Opening an issue or bug should be as easy as possible IMO.

I think that many questions don't need to be answered as podman info shows that data.

vrothberg · 2022-11-22T08:54:56Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+      options:
+        - main


I am also in favor of nuking.

podman info shows that information

vrothberg · 2022-11-22T08:55:39Z

.github/ISSUE_TEMPLATE/bug_report.yaml

+    id: os
+    attributes:
+      label: Operating System 
+      description: What operating system are you using?


I am also in favor of nuking.

podman info shows that information

It's not listing Debian and OpenSUSE, for instance, but puts all RH distros first.

vrothberg · 2022-11-22T08:58:58Z

@mohanboddu Can you enable this on your fork so I could test it there? I much rather try it than looking at yaml.

In the current template, this is all inside HTML comments. That minimizes clutter. Does this "attributes" thing also guarantee that the new template will have this cruft in comments?

@Luap99 @edsantiago please take a look at https://github.com/mohanboddu/podman/issues/new/choose, I hope this helps to clear some of your questions

I like the workflow there a lot! I am sure we can address the open concerns.

Luap99 · 2022-11-29T17:41:15Z

@Luap99 @edsantiago please take a look at https://github.com/mohanboddu/podman/issues/new/choose, I hope this helps to clear some of your questions

Thanks, this looks very nice.

You have some validate problems with trailing white spaces.

vrothberg

Just one final nit but LGTM. Thanks a lot!

.github/ISSUE_TEMPLATE/bug_report.yaml

Adding "Bug Report" and "Feature Request" templates, this will help with filing the tickets and also finding the information once filed. Signed-off-by: Mohan Boddu <[email protected]>

mohanboddu · 2022-11-30T19:08:35Z

You have some validate problems with trailing white spaces.

Thanks @Luap99 , I fixed the trailing white spaces

github-actions · 2022-12-31T00:06:00Z

A friendly reminder that this PR had no activity for 30 days.

rhatdan · 2023-01-03T14:06:44Z

@mohanboddu Is this ready to go in?

mohanboddu · 2023-01-03T14:31:02Z

@rhatdan I have addressed all the comments in the PR, it should be good to go if there are no other concerns.

rhatdan · 2023-01-03T15:20:14Z

/lgtm
/approve

openshift-ci · 2023-01-03T15:20:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohanboddu, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 21, 2022

mohanboddu force-pushed the issue_templates branch from 833f77c to 9e6a9ad Compare November 21, 2022 16:29

mheon reviewed Nov 21, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved

mheon reviewed Nov 21, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved

Luap99 reviewed Nov 21, 2022

View reviewed changes

edsantiago reviewed Nov 21, 2022

View reviewed changes

mohanboddu force-pushed the issue_templates branch 2 times, most recently from ae2a111 to f8ff8b2 Compare November 21, 2022 22:20

mohanboddu force-pushed the issue_templates branch from f8ff8b2 to 33dbbdf Compare November 21, 2022 22:27

vrothberg reviewed Nov 22, 2022

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022

mohanboddu force-pushed the issue_templates branch 2 times, most recently from 7ee37a4 to c160f04 Compare November 29, 2022 16:01

mohanboddu changed the title ~~[WIP] Update the issue templates~~ Update the issue templates Nov 29, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022

mohanboddu force-pushed the issue_templates branch from c160f04 to 5d560c7 Compare November 29, 2022 16:10

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2022

mohanboddu force-pushed the issue_templates branch 2 times, most recently from 25fd1cf to 41050ac Compare November 30, 2022 03:51

vrothberg reviewed Nov 30, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved

Update the issue templates

2b6cf1d

Adding "Bug Report" and "Feature Request" templates, this will help with filing the tickets and also finding the information once filed. Signed-off-by: Mohan Boddu <[email protected]>

mohanboddu force-pushed the issue_templates branch from 41050ac to 2b6cf1d Compare November 30, 2022 19:07

github-actions bot added the stale-pr label Dec 31, 2022

openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jan 3, 2023

rhatdan added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None and removed stale-pr release-note-none labels Jan 3, 2023

openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jan 3, 2023

openshift-ci bot assigned rhatdan Jan 3, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023

openshift-merge-robot merged commit 2dcf6b1 into containers:main Jan 3, 2023

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the issue templates #16572

Update the issue templates #16572

mohanboddu commented Nov 21, 2022 •

edited by rhatdan

Loading

Luap99 commented Nov 21, 2022

Luap99 left a comment

Luap99 Nov 21, 2022

flouthoc Nov 21, 2022

Luap99 Nov 21, 2022

Luap99 Nov 21, 2022

mohanboddu Nov 21, 2022 •

edited

Loading

mohanboddu Nov 30, 2022

edsantiago left a comment

edsantiago Nov 21, 2022

mohanboddu Nov 21, 2022

edsantiago Nov 21, 2022

mohanboddu Nov 29, 2022

edsantiago Nov 21, 2022

vrothberg Nov 22, 2022

edsantiago Nov 21, 2022

vrothberg Nov 22, 2022

mohanboddu commented Nov 21, 2022

mohanboddu commented Nov 21, 2022

vrothberg left a comment

vrothberg Nov 22, 2022

vrothberg Nov 22, 2022

vrothberg commented Nov 22, 2022

Luap99 commented Nov 29, 2022

vrothberg left a comment

mohanboddu commented Nov 30, 2022

github-actions bot commented Dec 31, 2022

rhatdan commented Jan 3, 2023

mohanboddu commented Jan 3, 2023

rhatdan commented Jan 3, 2023

openshift-ci bot commented Jan 3, 2023


		Also, there is a running list of known issues in the [Podman Troubleshooting Guide](https://github.com/containers/podman/blob/main/troubleshooting.md), please reference that page before opening a new issue.

		If you are filing a bug against `podman build`, please instead file a bug against Buildah (https://github.com/containers/buildah/issues). Podman build executes Buildah to perform container builds, and as such the Buildah maintainers are best equipped to handle these bugs.

		value: \|
		Thanks for taking the time to fill out this bug report!

Update the issue templates #16572

Update the issue templates #16572

Conversation

mohanboddu commented Nov 21, 2022 • edited by rhatdan Loading

Does this PR introduce a user-facing change?

Luap99 commented Nov 21, 2022

Luap99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohanboddu Nov 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edsantiago left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohanboddu commented Nov 21, 2022

mohanboddu commented Nov 21, 2022

vrothberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vrothberg commented Nov 22, 2022

Luap99 commented Nov 29, 2022

vrothberg left a comment

Choose a reason for hiding this comment

mohanboddu commented Nov 30, 2022

github-actions bot commented Dec 31, 2022

rhatdan commented Jan 3, 2023

mohanboddu commented Jan 3, 2023

rhatdan commented Jan 3, 2023

openshift-ci bot commented Jan 3, 2023

mohanboddu commented Nov 21, 2022 •

edited by rhatdan

Loading

mohanboddu Nov 21, 2022 •

edited

Loading