Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.3] v4.3 backports #16519

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 15, 2022

Does this PR introduce a user-facing change?

None

Obsoletes #16516

vrothberg and others added 2 commits November 15, 2022 19:22
Bump the timeout waiting for the container to process the signal.
The comparatively short timeout is most likely responsible for
flakes in gating tests.

Fixes: containers#16091
Signed-off-by: Valentin Rothberg <[email protected]>
(cherry picked from commit f0ba2d8)
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
(cherry picked from commit ae9a2d2)
Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 15, 2022
@edsantiago
Copy link
Member

LGTM

@mheon
Copy link
Member

mheon commented Nov 15, 2022

Sure
/lgtm
/approve
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8dfa337 into containers:v4.3 Nov 15, 2022
@lsm5 lsm5 deleted the v4.3-backports branch November 16, 2022 10:19
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants